Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting.md to clarify disabling any other formatting extensions #4091

Merged
merged 4 commits into from
Nov 19, 2021

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This is an attempt to clarify the need to disable other formatting extensions when developing on the project.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

@takameyer
Copy link
Contributor

We could also just say to set eslint as the default validator:

"eslint.validate": ["typescript", "typescriptreact", "javascript"]

@kraenhansen
Copy link
Member Author

We could also just say to set eslint as the default validator

I haven't verified the setting you pasted, but I've added it to the PR.
I personally had this in my global settings:

    "[javascript]": {
        "editor.defaultFormatter": "dbaeumer.vscode-eslint"
    },
    "[typescript]": {
        "editor.defaultFormatter": "dbaeumer.vscode-eslint"
    },

I wonder if these settings could go into the .vscode/settings.json file instead?

@takameyer
Copy link
Contributor

takameyer commented Nov 19, 2021

I wonder if these settings could go into the .vscode/settings.json file instead?

That sounds like an even better idea.

Copy link
Contributor

@tomduncalf tomduncalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine 👍 Thanks!

@kraenhansen kraenhansen merged commit 4e30b80 into master Nov 19, 2021
@kraenhansen kraenhansen deleted the kh/clarify-linting-docs branch November 19, 2021 15:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants