-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #600: Empty Note error #676
Conversation
@siddxharth is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for your contribution 😊.
Please reference the issue number in the description if you are fixing a bug.
If you are implementing a feature request, please check with the maintainers that the feature will be accepted first.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Okay, I'll fix it |
I've made a new pull request. Made a couple of changes...
|
I've made a new commit, it should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siddxharth Thanks for adding the fix.
@all-contributors please add @siddxharth for Code |
I've put up a pull request to add @siddxharth! 🎉 |
Description
Fix the issue where the user could create a new note with an empty title and note body. Now the button is disabled if the title and body fields both are empty.
Fixes # (issue)
#600
How Has This Been Tested?
I tested these changes myself by running the server locally with the credentials provided in the README file.
Checklist: