Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #600: Empty Note error #676

Merged
merged 6 commits into from
Oct 13, 2022
Merged

Fixed #600: Empty Note error #676

merged 6 commits into from
Oct 13, 2022

Conversation

siddxharth
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Fix the issue where the user could create a new note with an empty title and note body. Now the button is disabled if the title and body fields both are empty.

Fixes # (issue)

#600

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I tested these changes myself by running the server locally with the credentials provided in the README file.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Oct 10, 2022

@siddxharth is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 😊.
Please reference the issue number in the description if you are fixing a bug.
If you are implementing a feature request, please check with the maintainers that the feature will be accepted first.

@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 7:19AM (UTC)

@Angryman18
Copy link
Member

Screenshot from 2022-10-11 07-52-21
can you fix this '+' button also. and make it center

@siddxharth
Copy link
Contributor Author

Okay, I'll fix it

@siddxharth
Copy link
Contributor Author

I've made a new pull request. Made a couple of changes...

  1. The Create button is now centred.
  2. The note title and content will be considered empty even if it only contains spaces.

src/plays/keeper/CreateArea.jsx Outdated Show resolved Hide resolved
src/plays/keeper/CreateArea.jsx Outdated Show resolved Hide resolved
src/plays/keeper/CreateArea.jsx Outdated Show resolved Hide resolved
@siddxharth
Copy link
Contributor Author

I've made a new commit, it should be good now.

Copy link
Member

@Angryman18 Angryman18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddxharth Thanks for adding the fix.

@atapas atapas added the hacktoberfest-accepted hacktoberfest-accepted label Oct 13, 2022
@atapas atapas linked an issue Oct 13, 2022 that may be closed by this pull request
@atapas atapas merged commit 11196e4 into reactplay:main Oct 13, 2022
@atapas
Copy link
Member

atapas commented Oct 13, 2022

@all-contributors please add @siddxharth for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @siddxharth! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Empty Note error
3 participants