Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Bug report]: Empty Note error #600

Closed
muzaffar640 opened this issue Oct 3, 2022 · 5 comments · Fixed by #676
Closed

🐛 [Bug report]: Empty Note error #600

muzaffar640 opened this issue Oct 3, 2022 · 5 comments · Fixed by #676
Assignees
@siddxharth @thisisbillall
Labels
bug Something isn't working hacktoberfest

Comments

@muzaffar640
Copy link
Contributor

Describe the bug
The user has the ability to make blank notes. If the Note Title and Note Content are both blank, no user should be able to create an empty note.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Keeper App
  2. Click on the + button keeping both Note Title and Note Content empty.

Expected behavior
Users shouldn't be able to create any empty notes and should instead receive some sort of popup notification asking them to "Please provide some valid data."

Screenshots
Screenshot 2022-10-04 at 12 31 50 AM

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]

Smartphone (please complete the following information):

  • Device: Redmi K20 pro
  • OS: Android
  • Browser: Chrome

I will be more than happy to fix it. Let me know if this makes sense.
@muzaffar640 muzaffar640 added the bug Something isn't working label Oct 3, 2022
@thisisbillall
Copy link

Can I take this?

@atapas
Copy link
Member

atapas commented Oct 5, 2022

Can I take this?

Assigned to you

@thisisbillall
Copy link

yes , thanks

@siddxharth
Copy link
Contributor

Hey, can I work on this too?

@siddxharth siddxharth mentioned this issue Oct 10, 2022
Merged
5 tasks
@siddxharth
Copy link
Contributor

Hey @Angryman18, I've made a pull request fixing the bug. Could you please review that?

@atapas atapas linked a pull request Oct 13, 2022 that will close this issue
Fixed #600: Empty Note error #676
Merged
5 tasks
atapas added a commit that referenced this issue Oct 13, 2022
@siddxharth @Angryman18 @atapas
Fixed #600: Empty Note error (#676)
11196e4 
* Disable button for empty notes

* Fix Create Button, Use Trim to check null string

* Move length expressions into variables

* Simplify disabled button

Co-authored-by: Shyam Mahanta <[email protected]>
Co-authored-by: Tapas Adhikary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siddxharth siddxharth

@thisisbillall thisisbillall

Labels
bug Something isn't working hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #600: Empty Note error
4 participants
@atapas @muzaffar640 @siddxharth @thisisbillall