Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .eslintrc to resolve https://github.com/reach/router/issues/64 #68

Closed
wants to merge 1 commit into from

Conversation

stunstunstun
Copy link
Contributor

I would like to phase out the issues #64

First of all, We can find that is missing in props validation

.eslintrc

  "rules": {
    "react/prop-types": ["warn", { "ignore": ["children"] }]
  }

If all props are validated, how about replacing the warn level with the error?

@stunstunstun stunstunstun deleted the devops/eslint branch June 11, 2018 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant