Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all the right propTypes #64

Closed
ryanflorence opened this issue Jun 9, 2018 · 2 comments
Closed

Add all the right propTypes #64

ryanflorence opened this issue Jun 9, 2018 · 2 comments
Labels
good first issue Good for newcomers

Comments

@ryanflorence
Copy link
Member

I was messing around w/ using flow or typescript for this project and so I was lazy on propTypes, but it's time to put them all in. PRs welcome, or I'll get to it eventually.
@ryanflorence ryanflorence added the good first issue Good for newcomers label Jun 9, 2018
@zhujinxuan
Copy link

I am thinking about making a PR. Which of the following ways would you prefer:

  1. add flow type to the source files, and also provides .js.flow. This will enable type check when developing and submitting PRs to router
  2. add .js.flow only

@ryanflorence
Copy link
Member Author

Just propTypes, no flow or TS

stunstunstun pushed a commit to stunstunstun/router that referenced this issue Jun 11, 2018
Create .eslintrc to resolve reach#64
3a44bfb
@stunstunstun stunstunstun mentioned this issue Jun 11, 2018
Closed
stunstunstun added a commit to stunstunstun/router that referenced this issue Jun 11, 2018
@stunstunstun
Create .eslintrc to resolve reach#64
a4169ee
@stunstunstun stunstunstun mentioned this issue Jun 11, 2018
Merged
@jednano jednano mentioned this issue Aug 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanflorence @zhujinxuan