Merge develop #66
Merged
Merge develop #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sourcery AI <>
* Add .circleci/config.yml * Add .circleci/config.yml * Add .circleci/config.yml
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
pip_chill/pip_chill.py
Outdated
| def __hash__(self): | ||
| return hash(self.name) | ||
|
|
||
| def __repr__(self): | ||
| return '<{}.{} instance "{}">'.format( |
There was a problem hiding this comment.
f-string is easier to read, write, and less computationally expensive than legacy string formatting. More details.
pip_chill/pip_chill.py
Outdated
|
|
||
| def __str__(self): | ||
| if self.required_by: | ||
| return "# {}=={} # Installed as dependency for {}".format( |
There was a problem hiding this comment.
Likewise, Consider using f-string instead.
pip_chill/pip_chill.py
Outdated
| return "# {}=={} # Installed as dependency for {}".format( | ||
| self.name, self.version, ", ".join(self.required_by) | ||
| ) | ||
| return "{}=={}".format(self.name, self.version) |
There was a problem hiding this comment.
As above, Consider using f-string instead.
Bump version from current to 1.0.3
Use new Docker environment
Return to the Python orb approach
* Added a --no-chill option (#36) * Bump version to 1.0.1 * Fix failing Flake8 test * Update history * Add --no-chill command line option. Fixes #34 * Remove click and add black to the requirements file * Version update * Remove black - not a dev requirement * 'Refactored by Sourcery' (#37) Co-authored-by: Sourcery AI <> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> * Version 1.0.1 (#40) * Bump version to 1.0.1 * Fix failing Flake8 test * Update history * Add --no-chill command line option. Fixes #34 * Remove click and add black to the requirements file * Version update * Remove black - not a dev requirement * 'Refactored by Sourcery' (#37) Co-authored-by: Sourcery AI <> * Update python-package.yml (#33) * Circleci project setup (#39) * Add .circleci/config.yml * Add .circleci/config.yml * Add .circleci/config.yml * Update README with --no-chill switch Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> * Update github repo url (#50) * Fix GitHub repo URL (#56) Will fix Travis tests later * Sort required_by * Update README to match new output * Update github repo url (#50) * Fix GitHub repo URL (#56) Will fix Travis tests later * Sort required_by * Update README to match new output * Add to AUTHORS --------- Co-authored-by: Ricardo Bánffy <[email protected]> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: AndrejK <[email protected]> Co-authored-by: xatier <[email protected]>
Co-authored-by: Sourcery AI <>
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
pip_chill/pip_chill.py
Outdated
| def __repr__(self): | ||
| return ( | ||
| f'<{self.__module__}.{self.__class__.__name__} instance "' | ||
| '{self.name}">' |
There was a problem hiding this comment.
Suggested change
| '{self.name}">' | |
| f'{self.name}">' |
If this was meant to be f-string then f prefix is missing. More details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.