Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a --no-chill option #36

Merged
merged 9 commits into from
Jan 18, 2021
Merged

Added a --no-chill option #36

merged 9 commits into from
Jan 18, 2021

Conversation

rbanffy
Copy link
Owner

@rbanffy rbanffy commented Jan 18, 2021

People have asked, so it's now here.

@sourcery-ai sourcery-ai bot mentioned this pull request Jan 18, 2021
Merged
@sourcery-ai
'Refactored by Sourcery' (#37)
49c066b 
Co-authored-by: Sourcery AI <>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 18, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.62%.

Quality metrics Before After Change
Complexity 4.34 ⭐ 4.56 ⭐ 0.22 👎
Method Length 31.30 ⭐ 32.10 ⭐ 0.80 👎
Working memory 6.42 🙂 6.43 🙂 0.01 👎
Quality 80.58% ⭐ 79.96% ⭐ -0.62% 👎
Other metrics Before After Change
Lines 256 273 17
Changed files Quality Before Quality After Quality Change
pip_chill/cli.py 67.06% 🙂 65.16% 🙂 -1.90% 👎
pip_chill/pip_chill.py 71.43% 🙂 69.67% 🙂 -1.76% 👎
tests/test_pip_chill.py 87.43% ⭐ 87.48% ⭐ 0.05% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pip_chill/pip_chill.py chill 22 😞 138 😞 8 🙂 49.23% 😞 Refactor to reduce nesting. Try splitting into smaller methods
tests/test_pip_chill.py TestPip_chill.test_pip_ommitted.test_all.test_hashes.test_command_line_interface_omits_ignored 1 ⭐ 52 ⭐ 10 😞 75.17% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@rbanffy rbanffy merged commit 6d33071 into master Jan 18, 2021
rbanffy added a commit that referenced this pull request Apr 15, 2023
@kevin-paulson-mindbridge-ai @rbanffy
@sourcery-ai @andrejkurusiov @xatier
Resolve: Inconsistent sort for "Installed as dependency for" (#64)
9d4f398 
* Added a --no-chill option (#36)

* Bump version to 1.0.1

* Fix failing Flake8 test

* Update history

* Add --no-chill command line option. Fixes #34

* Remove click and add black to the requirements file

* Version update

* Remove black - not a dev requirement

* 'Refactored by Sourcery' (#37)

Co-authored-by: Sourcery AI <>

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

* Version 1.0.1 (#40)

* Bump version to 1.0.1

* Fix failing Flake8 test

* Update history

* Add --no-chill command line option. Fixes #34

* Remove click and add black to the requirements file

* Version update

* Remove black - not a dev requirement

* 'Refactored by Sourcery' (#37)

Co-authored-by: Sourcery AI <>

* Update python-package.yml (#33)

* Circleci project setup (#39)

* Add .circleci/config.yml

* Add .circleci/config.yml

* Add .circleci/config.yml

* Update README with --no-chill switch

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

* Update github repo url (#50)

* Fix GitHub repo URL (#56)

Will fix Travis tests later

* Sort required_by

* Update README to match new output

* Update github repo url (#50)

* Fix GitHub repo URL (#56)

Will fix Travis tests later

* Sort required_by

* Update README to match new output

* Add to AUTHORS

---------

Co-authored-by: Ricardo Bánffy <[email protected]>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: AndrejK <[email protected]>
Co-authored-by: xatier <[email protected]>
rbanffy added a commit that referenced this pull request Apr 15, 2023
@rbanffy @sourcery-ai
@kevin-paulson-mindbridge-ai @andrejkurusiov @xatier @Isaeiah
Merge develop (#66)
ba5149f 
* Bump version to 1.0.1

* Fix failing Flake8 test

* Update history

* Add --no-chill command line option. Fixes #34

* Remove click and add black to the requirements file

* Version update

* Remove black - not a dev requirement

* 'Refactored by Sourcery' (#37)

Co-authored-by: Sourcery AI <>

* Update python-package.yml (#33)

* Circleci project setup (#39)

* Add .circleci/config.yml

* Add .circleci/config.yml

* Add .circleci/config.yml

* Update README with --no-chill switch

* Update HISTORY and bump versions

* Remove __future__ import (we don't need it anymore)

* We only support Python 3+

* Add `ssort`

* Sort methods with `ssort`

* Version bump

* Remove Python 3.5 support

* Remove Python 3.6 support and move 3.10 out of dev

* Upgrade macOS image to 13.2 (Xcode 13.2.1)

* Time `tox` execution

* Update HISTORY.rst

* Update supported Python versions

* Update Python image version

* Update HISTORY.rst

Bump version from current to 1.0.3

* Update config.yml

Use new Docker environment

* Update config.yml

Return to the Python orb approach

* Added note so contributors start from the develop branch

* Remove support for 3.6 in tests, add 3.10, 3.11

* Update pip before installing travis-tox

* Add Python 3.11 to some platforms in travis

* Resolve: Inconsistent sort for "Installed as dependency for" (#64)

* Added a --no-chill option (#36)

* Bump version to 1.0.1

* Fix failing Flake8 test

* Update history

* Add --no-chill command line option. Fixes #34

* Remove click and add black to the requirements file

* Version update

* Remove black - not a dev requirement

* 'Refactored by Sourcery' (#37)

Co-authored-by: Sourcery AI <>

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

* Version 1.0.1 (#40)

* Bump version to 1.0.1

* Fix failing Flake8 test

* Update history

* Add --no-chill command line option. Fixes #34

* Remove click and add black to the requirements file

* Version update

* Remove black - not a dev requirement

* 'Refactored by Sourcery' (#37)

Co-authored-by: Sourcery AI <>

* Update python-package.yml (#33)

* Circleci project setup (#39)

* Add .circleci/config.yml

* Add .circleci/config.yml

* Add .circleci/config.yml

* Update README with --no-chill switch

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

* Update github repo url (#50)

* Fix GitHub repo URL (#56)

Will fix Travis tests later

* Sort required_by

* Update README to match new output

* Update github repo url (#50)

* Fix GitHub repo URL (#56)

Will fix Travis tests later

* Sort required_by

* Update README to match new output

* Add to AUTHORS

---------

Co-authored-by: Ricardo Bánffy <[email protected]>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: AndrejK <[email protected]>
Co-authored-by: xatier <[email protected]>

* 'Refactored by Sourcery' (#67)

Co-authored-by: Sourcery AI <>

* Fix Flake8 flagged issues

* Apply Black

* Fix version numbers

* Fix f-strings

---------

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: Kevin Paulson <[email protected]>
Co-authored-by: AndrejK <[email protected]>
Co-authored-by: xatier <[email protected]>
Co-authored-by: Ricardo Bánffy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rbanffy