Remove ray.tasks() from API. #7807
Conversation
|
cc @edoakes regarding removing |
|
Can one of the admins verify this patch? |
|
Test PASSed. |
| # TODO(edoakes): there are dummy object IDs being created in | ||
| # includes/task.pxi before the core worker is initialized. |
There was a problem hiding this comment.
@edoakes can you confirm that it's ok to remove this comment?
There was a problem hiding this comment.
This comment means we should be able to remove the hasattr check below and the related in_core_worker flag. Let's either remove those or leave the TODO modified to say those can be removed now.
There was a problem hiding this comment.
Done. Initially tried removing the code, but ran into some errors, so decided to just update the comment.
There was a problem hiding this comment.
In particular, ran into the error
AttributeError: 'Worker' object has no attribute 'core_worker'
here
| @@ -167,6 +167,39 @@ def f(): | |||
| assert "success" in out | |||
|
|
|||
|
|
|||
| def test_cleanup_on_driver_exit(call_ray_start): | |||
There was a problem hiding this comment.
Adding this test to replace test_monitors.py (which wasn't even being run anyway).
|
Test FAILed. |
|
Test FAILed. |
This reverts commit e254d58.
|
Test FAILed. |
This also removes some other unnecessary code.