Remove ray.tasks() from API. (#7807)

ray-project · Apr 1, 2020 · b011c60 · b011c60
1 parent 780c1c3
commit b011c60
Show file tree

Hide file tree

Showing 13 changed files with 38 additions and 622 deletions.
diff --git a/doc/source/package-ref.rst b/doc/source/package-ref.rst
@@ -34,8 +34,6 @@ Inspect the Cluster State
 
 .. autofunction:: ray.nodes
 
-.. autofunction:: ray.tasks
-
 .. autofunction:: ray.objects
 
 .. autofunction:: ray.timeline

diff --git a/python/ray/__init__.py b/python/ray/__init__.py
@@ -59,7 +59,7 @@
 _config = _Config()
 
 from ray.profiling import profile # noqa: E402
-from ray.state import (jobs, nodes, actors, tasks, objects, timeline,
+from ray.state import (jobs, nodes, actors, objects, timeline,
  object_transfer_timeline, cluster_resources,
  available_resources, errors) # noqa: E402
 from ray.worker import (
@@ -99,7 +99,6 @@
  "jobs",
  "nodes",
  "actors",
- "tasks",
  "objects",
  "timeline",
  "object_transfer_timeline",

diff --git a/python/ray/_raylet.pyx b/python/ray/_raylet.pyx
@@ -75,7 +75,6 @@ from ray.includes.libcoreworker cimport (
  CFiberEvent,
  CActorHandle,
 )
-from ray.includes.task cimport CTaskSpec
 from ray.includes.ray_config cimport RayConfig
 
 import ray
@@ -98,7 +97,6 @@ cimport cpython
 include "includes/unique_ids.pxi"
 include "includes/ray_config.pxi"
 include "includes/function_descriptor.pxi"
-include "includes/task.pxi"
 include "includes/buffer.pxi"
 include "includes/common.pxi"
 include "includes/serialization.pxi"

diff --git a/python/ray/includes/libcoreworker.pxd b/python/ray/includes/libcoreworker.pxd
@@ -36,7 +36,6 @@ from ray.includes.common cimport (
 from ray.includes.function_descriptor cimport (
  CFunctionDescriptor,
 )
-from ray.includes.task cimport CTaskSpec
 
 ctypedef unordered_map[c_string, c_vector[pair[int64_t, double]]] \
  ResourceMappingType

diff --git a/python/ray/includes/task.pxd b/python/ray/includes/task.pxd
diff --git a/python/ray/includes/task.pxi b/python/ray/includes/task.pxi
diff --git a/python/ray/includes/unique_ids.pxi b/python/ray/includes/unique_ids.pxi
@@ -134,8 +134,9 @@ cdef class ObjectID(BaseID):
  self.in_core_worker = False
 
  worker = ray.worker.global_worker
- # TODO(edoakes): there are dummy object IDs being created in
- # includes/task.pxi before the core worker is initialized.
+ # TODO(edoakes): We should be able to remove the in_core_worker flag.
+ # But there are still some dummy object IDs being created outside the
+ # context of a core worker.
  if hasattr(worker, "core_worker"):
  worker.core_worker.add_object_id_reference(self)
  self.in_core_worker = True