Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-automation] More flexibility on the pipeline #45254

Merged
merged 7 commits into from
May 13, 2024
Merged

[release-automation] More flexibility on the pipeline #45254

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3fc4e64
p
khluu May 10, 2024
b78f3a1
p
khluu May 10, 2024
42f606a
p
khluu May 10, 2024
31a0438
p
khluu May 10, 2024
5c088d1
p
khluu May 10, 2024
6c284c3
fix
khluu May 10, 2024
c5e5a0a
fix
khluu May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix 
Signed-off-by: khluu <[email protected]>
  • Loading branch information
@khluu
khluu committed May 10, 2024
commit c5e5a0a9fa1ae347629ed412696f4414a9a971bb
2 changes: 1 addition & 1 deletion ci/ray_ci/automation/ray_wheels_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def download_ray_wheels_from_s3(
full_directory_path = os.path.join(bazel_workspace_dir, directory_path)
minor_version = ray_version.split(".")[1]
full_platform = True if int(minor_version) % 10 == 0 else False
wheels = _get_wheel_names(ray_version, full_platform)
wheels = _get_wheel_names(ray_version=ray_version, full_platform=full_platform)
for wheel in wheels:
s3_key = f"releases/{ray_version}/{commit_hash}/{wheel}.whl"
download_wheel_from_s3(s3_key, full_directory_path)
Expand Down
8 changes: 6 additions & 2 deletions ci/ray_ci/automation/test_ray_wheels_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,9 @@ def test_download_ray_wheels_from_s3(
directory_path=tmp_dir,
)

mock_get_wheel_names.assert_called_with(ray_version, True)
mock_get_wheel_names.assert_called_with(
ray_version=ray_version, full_platform=True
)
assert mock_download_wheel.call_count == len(SAMPLE_WHEELS)
for i, call_args in enumerate(mock_download_wheel.call_args_list):
assert (
Expand Down Expand Up @@ -197,7 +199,9 @@ def test_download_ray_wheels_from_s3_partial_platform(
directory_path=tmp_dir,
)

mock_get_wheel_names.assert_called_with(ray_version, False)
mock_get_wheel_names.assert_called_with(
ray_version=ray_version, full_platform=False
)
assert mock_download_wheel.call_count == len(SAMPLE_WHEELS)
for i, call_args in enumerate(mock_download_wheel.call_args_list):
assert (
Expand Down
Loading