-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-automation] More flexibility on the pipeline #45254
Conversation
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
@@ -82,8 +92,9 @@ def download_ray_wheels_from_s3( | |||
directory_path: The directory to download the wheels to. | |||
""" | |||
full_directory_path = os.path.join(bazel_workspace_dir, directory_path) | |||
|
|||
wheels = _get_wheel_names(ray_version) | |||
_, minor_version, _ = ray_version.split(".") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might not always be 3 parts , maybe just take 2nd part without assuming it has 3 parts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ya I forgot about cases like 0.0.1.post1
. Updated to just grab the 2nd part
Signed-off-by: khluu <[email protected]>
) | ||
|
||
mock_get_wheel_names.assert_called_with(ray_version) | ||
mock_get_wheel_names.assert_called_with(ray_version, False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add full_platform=False
for readability?
it is actually often not recommended to use a boolean as an flag arg. a string or an enum is often more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: khluu <[email protected]>
) - Only upload `linux_x86_64`, `mac x86_64`, and `mac arm64` wheels unless it's a full platform release. - Each of the wheel sanity check step has its own block step. - Uploading wheels to PyPI no longer requires all sanity checks to pass. This is up for release manager to judge whether the wheels are ready. - Add key for each of the step. This is to support automation that checks for BK job status (it's better to retrieve jobs from BK and identify with key than job label) --------- Signed-off-by: khluu <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
) - Only upload `linux_x86_64`, `mac x86_64`, and `mac arm64` wheels unless it's a full platform release. - Each of the wheel sanity check step has its own block step. - Uploading wheels to PyPI no longer requires all sanity checks to pass. This is up for release manager to judge whether the wheels are ready. - Add key for each of the step. This is to support automation that checks for BK job status (it's better to retrieve jobs from BK and identify with key than job label) --------- Signed-off-by: khluu <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
) - Only upload `linux_x86_64`, `mac x86_64`, and `mac arm64` wheels unless it's a full platform release. - Each of the wheel sanity check step has its own block step. - Uploading wheels to PyPI no longer requires all sanity checks to pass. This is up for release manager to judge whether the wheels are ready. - Add key for each of the step. This is to support automation that checks for BK job status (it's better to retrieve jobs from BK and identify with key than job label) --------- Signed-off-by: khluu <[email protected]>
) - Only upload `linux_x86_64`, `mac x86_64`, and `mac arm64` wheels unless it's a full platform release. - Each of the wheel sanity check step has its own block step. - Uploading wheels to PyPI no longer requires all sanity checks to pass. This is up for release manager to judge whether the wheels are ready. - Add key for each of the step. This is to support automation that checks for BK job status (it's better to retrieve jobs from BK and identify with key than job label) --------- Signed-off-by: khluu <[email protected]> Signed-off-by: gchurch <[email protected]>
linux_x86_64
,mac x86_64
, andmac arm64
wheels unless it's a full platform release.