Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] fix test result upload on release branch #43859

Merged
merged 1 commit into from
Mar 10, 2024
Merged

[ci] fix test result upload on release branch #43859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/ray_ci/tester_container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ def run_tests(
def _persist_test_results(self, team: str, bazel_log_dir: str) -> None:
if os.environ.get("BUILDKITE_BRANCH") != "master":
logger.info("Skip upload test results. We only upload on master branch.")
return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you follow up with some unit tests?

I think we have some bad patterns of reading env vars too much in the middle of the programs. similar to the argument that global vars are bad. ideally, they should be read at the beginning and being passed in.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally

if os.environ.get("BUILDKITE_PIPELINE_ID") != PIPELINE_POSTMERGE:
logger.info(
"Skip upload test results. We only upload on postmerge pipeline."
Expand Down
Loading