[ci] fix test result upload on release branch #43859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-fix-upload-result
branch
from
9e533dc
to
b67a088
Compare
aslonnie
approved these changes
Mar 10, 2024
| @@ -110,6 +110,7 @@ def run_tests( | |||
| def _persist_test_results(self, team: str, bazel_log_dir: str) -> None: | |||
| if os.environ.get("BUILDKITE_BRANCH") != "master": | |||
| logger.info("Skip upload test results. We only upload on master branch.") | |||
| return | |||
There was a problem hiding this comment.
could you follow up with some unit tests?
I think we have some bad patterns of reading env vars too much in the middle of the programs. similar to the argument that global vars are bad. ideally, they should be read at the beginning and being passed in.
Merged
aslonnie
pushed a commit
that referenced
this pull request
Mar 13, 2024
Pick of #43859 to fix test result uploading Signed-off-by: can <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
should not upload test results on the release branch. missed a return statement here. Signed-off-by: can <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not upload test results on the release branch. I missed a return statement here.
Test: