Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Remove old grpc code #39863

Merged
merged 18 commits into from
Sep 28, 2023
Prev Previous commit
Next Next commit
Update
Signed-off-by: Sihan Wang <[email protected]>
  • Loading branch information
sihanwang41 committed Sep 26, 2023
commit 483e89fcee575e72b885ab565529ba0034f9dc38
4 changes: 3 additions & 1 deletion python/ray/serve/_private/proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from starlette.types import Message, Receive

import ray
from ray._private.tls_utils import add_port_to_grpc_server
from ray._private.utils import get_or_create_event_loop
from ray._raylet import StreamingObjectRefGenerator
from ray.actor import ActorHandle
Expand Down Expand Up @@ -1614,7 +1615,8 @@ async def run_grpc_server(self):
grpc_server = create_serve_grpc_server(
service_handler_factory=self.grpc_proxy.service_handler_factory,
)
grpc_server.add_insecure_port(f"[::]:{self.grpc_port}")

add_port_to_grpc_server(grpc_server, f"[::]:{self.grpc_port}")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add TLS support


# Dummy servicer is used to be callable for the gRPC server. Serve have a
# custom gRPC server implementation to redirect calls into gRPCProxy.
Expand Down
Loading