[Serve] Remove old grpc code #39863
Merged
[Serve] Remove old grpc code #39863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihan Wang <[email protected]>
sihanwang41
commented
Sep 26, 2023
| try: | ||
| # Depending on whether RAY_USE_TLS is on, `add_port_to_grpc_server` | ||
| # can create a secure or insecure channel | ||
| self.grpc_port = add_port_to_grpc_server(self.server, address) |
There was a problem hiding this comment.
@GeneDer do we support TLS (secure channel) in the current grpc proxy?
There was a problem hiding this comment.
Right now it's just using unsecured port https://github.com/ray-project/ray/blob/master/python/ray/serve/_private/proxy.py#L1617 But adding support should be pretty easy.
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
sihanwang41
force-pushed
the
remove_old_grpc
branch
from
ada850a
to
b134ce7
Compare
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
sihanwang41
force-pushed
the
remove_old_grpc
branch
from
d338b96
to
1bb9011
Compare
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
sihanwang41
commented
Sep 26, 2023
| @@ -151,49 +147,41 @@ def _start_controller( | |||
| "max_concurrency": CONTROLLER_MAX_CONCURRENCY, | |||
| } | |||
|
|
|||
| if FLAG_DISABLE_PROXY: | |||
There was a problem hiding this comment.
no logic change, only remove the if case
python/ray/serve/_private/proxy.py
Outdated
| @@ -1605,7 +1606,8 @@ async def run_grpc_server(self): | |||
| grpc_server = create_serve_grpc_server( | |||
| service_handler_factory=self.grpc_proxy.service_handler_factory, | |||
| ) | |||
| grpc_server.add_insecure_port(f"[::]:{self.grpc_port}") | |||
|
|
|||
| add_port_to_grpc_server(grpc_server, f"[::]:{self.grpc_port}") | |||
There was a problem hiding this comment.
Add TLS support
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
|
@sihanwang41 could you please separate (7) out into its own PR so this is purely removing the existing stuff? |
Signed-off-by: Sihan Wang <[email protected]>
edoakes
approved these changes
Sep 27, 2023
done |
zcin
approved these changes
Sep 27, 2023
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
1. Remove is_driver_deployment API 2. Remove the grpc driver 3. Remove driver deployment. 4. Rmove disable_httpproxy flag 5. Remove related unit tests 6. Remove old gRPC proto schema Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.