Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Unbold "Use Cases" in sidebar #39295

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

peytondmurray
Copy link
Contributor

Why are these changes needed?

The Use Cases sidebar link is bolded. #39172 is a request to unbold it, so this PR does that.

We now have the ability to specify styles for any of the links in the sidebar, so if another request comes through, there's now a mechanism to change that easily.

Related issue number

Closes #39172.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thank you, @peytondmurray! cc: @matthewdeng

Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so happy

@matthewdeng matthewdeng merged commit 6e284eb into ray-project:master Sep 8, 2023
13 of 15 checks passed
@peytondmurray peytondmurray deleted the unbold-use-cases branch September 8, 2023 22:29
@angelinalg angelinalg added docs An issue or change related to documentation v2.7.0-pick labels Sep 8, 2023
angelinalg pushed a commit to angelinalg/ray that referenced this pull request Sep 9, 2023
GeneDer pushed a commit that referenced this pull request Sep 9, 2023
#39510)

* Update metrics.md (#38512)

1. there are 3 dashboards in the folder now. Refer to the folder instead of only 1 dashboard
2. include "Copy" since people need to copy this from the head node to the Grafana server

Signed-off-by: Huaiwei Sun <[email protected]>

* polish observability (o11y) docs (#39069)

Signed-off-by: Huaiwei Sun <[email protected]>
Co-authored-by: angelinalg <[email protected]>
Co-authored-by: matthewdeng <[email protected]>

* [Doc] Unbold "Use Cases" in sidebar (#39295)

Signed-off-by: pdmurray <[email protected]>

* [docs] Cleanup for other AIR concepts (#39400)

* [doc][clusters] add doc for setting up Ray and K8s (#39408)

---------

Signed-off-by: Huaiwei Sun <[email protected]>
Signed-off-by: pdmurray <[email protected]>
Co-authored-by: Huaiwei Sun <[email protected]>
Co-authored-by: matthewdeng <[email protected]>
Co-authored-by: Peyton Murray <[email protected]>
Co-authored-by: Richard Liaw <[email protected]>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Unbold Use Cases in LHS nav
3 participants