-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics.md #38512
Merged
Merged
Update metrics.md #38512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsun94
requested review from
architkulkarni,
wuisawesome,
DmitriGekhtman,
maxpumperla,
pcmoritz,
kevin85421 and
a team
as code owners
August 16, 2023 19:14
alanwguo
approved these changes
Aug 16, 2023
rkooo567
approved these changes
Aug 16, 2023
Need doc owner approval cc @angelinalg ? |
angelinalg
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay!
Can we cherrypick this one? @angelinalg I may have another doc fix up soon. |
scottsun94
force-pushed
the
scottsun94-patch-1
branch
from
September 6, 2023 20:31
173df1b
to
1654bb5
Compare
1. there are 3 dashboards in the folder now. Refer to the folder instead of only 1 dashboard 2. include "Copy" since people need to copy this from the head node to the Grafana server Signed-off-by: Huaiwei Sun <[email protected]>
Signed-off-by: Huaiwei Sun <[email protected]>
scottsun94
force-pushed
the
scottsun94-patch-1
branch
from
September 7, 2023 02:21
1654bb5
to
2d1f2d2
Compare
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Sep 8, 2023
1. there are 3 dashboards in the folder now. Refer to the folder instead of only 1 dashboard 2. include "Copy" since people need to copy this from the head node to the Grafana server Signed-off-by: Huaiwei Sun <[email protected]>
angelinalg
pushed a commit
to angelinalg/ray
that referenced
this pull request
Sep 9, 2023
1. there are 3 dashboards in the folder now. Refer to the folder instead of only 1 dashboard 2. include "Copy" since people need to copy this from the head node to the Grafana server Signed-off-by: Huaiwei Sun <[email protected]>
8 tasks
GeneDer
pushed a commit
that referenced
this pull request
Sep 9, 2023
#39510) * Update metrics.md (#38512) 1. there are 3 dashboards in the folder now. Refer to the folder instead of only 1 dashboard 2. include "Copy" since people need to copy this from the head node to the Grafana server Signed-off-by: Huaiwei Sun <[email protected]> * polish observability (o11y) docs (#39069) Signed-off-by: Huaiwei Sun <[email protected]> Co-authored-by: angelinalg <[email protected]> Co-authored-by: matthewdeng <[email protected]> * [Doc] Unbold "Use Cases" in sidebar (#39295) Signed-off-by: pdmurray <[email protected]> * [docs] Cleanup for other AIR concepts (#39400) * [doc][clusters] add doc for setting up Ray and K8s (#39408) --------- Signed-off-by: Huaiwei Sun <[email protected]> Signed-off-by: pdmurray <[email protected]> Co-authored-by: Huaiwei Sun <[email protected]> Co-authored-by: matthewdeng <[email protected]> Co-authored-by: Peyton Murray <[email protected]> Co-authored-by: Richard Liaw <[email protected]>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
1. there are 3 dashboards in the folder now. Refer to the folder instead of only 1 dashboard 2. include "Copy" since people need to copy this from the head node to the Grafana server Signed-off-by: Huaiwei Sun <[email protected]> Signed-off-by: Jim Thompson <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
1. there are 3 dashboards in the folder now. Refer to the folder instead of only 1 dashboard 2. include "Copy" since people need to copy this from the head node to the Grafana server Signed-off-by: Huaiwei Sun <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
People ran into issues and users share this tip with each other
https://ray-distributed.slack.com/archives/C01DLHZHRBJ/p1690534092815279
This pr updates the outdated doc.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.