Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Optimize computer vision example code #38712

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Aug 22, 2023

Why are these changes needed?

The computer_vision.py example test previously took more than 15 minutes to run. With limit pushdown and the changes in this PR, this test now only takes ~6 minutes to run.

image

https://github.com/ray-project/ray/blob/master/doc/source/ray-air/doc_code/computer_vision.py

Related issue number

Closes #35692

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Manually set parallelism

Signed-off-by: Balaji Veeramani <[email protected]>
Update BUILD

Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani marked this pull request as ready for review August 22, 2023 17:53
@bveeramani bveeramani merged commit 0f4a685 into ray-project:master Aug 22, 2023
18 of 20 checks passed
@bveeramani bveeramani deleted the computer-vision branch August 22, 2023 18:00
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
The computer_vision.py example test previously took more than 15 minutes to run. With limit pushdown and the changes in this PR, this test now only takes ~6 minutes to run.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: e428265 <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
The computer_vision.py example test previously took more than 15 minutes to run. With limit pushdown and the changes in this PR, this test now only takes ~6 minutes to run.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AIR] computer_vision_test is too big
2 participants