Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] computer_vision_test is too big #35692

Closed
gjoliver opened this issue May 23, 2023 · 3 comments · Fixed by #38712
Closed

[AIR] computer_vision_test is too big #35692

gjoliver opened this issue May 23, 2023 · 3 comments · Fixed by #38712
Assignees
Labels
docs An issue or change related to documentation P1 Issue that should be fixed within a few weeks

Comments

@gjoliver
Copy link
Member

Description

our ray_air/doc_code/computer_vision.py test is too heavy.
it runs 5 batch inference jobs in both tf and torch in a loop, and is taking longer than 15mins to finish.
we changed it to "enormous", to unblock the release for now.

it would be nice to reduce the size while still testing the functionalities.
for example, use a much smaller dataet, or run this on GPU node, etc.
the problem with large tests is that our CI takes a long time to finish.

cc @richardliaw

Link

https://github.com/ray-project/ray/blob/master/doc/source/ray-air/doc_code/computer_vision.py

@gjoliver gjoliver added P1 Issue that should be fixed within a few weeks docs An issue or change related to documentation air labels May 23, 2023
@bveeramani
Copy link
Member

Thanks! The dataset size is limited to 32 rows, so I'm not how much using a smaller dataset will help, but I'll take a look.

@richardliaw
Copy link
Contributor

richardliaw commented May 24, 2023 via email

@bveeramani
Copy link
Member

Yeah, no harm in doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants