Revert "Remove grpcio from minimal dependency" #38453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ef2a040.
pcmoritz
requested review from
architkulkarni,
wuisawesome,
DmitriGekhtman,
maxpumperla,
kevin85421,
a team,
richardliaw,
ericl and
edoakes
as code owners
rynewang
added a commit
that referenced
this pull request
Aug 15, 2023
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…ay-project#38453) This reverts commit ef2a040. Signed-off-by: NripeshN <[email protected]>
pcmoritz
pushed a commit
that referenced
this pull request
Aug 16, 2023
Reverts #38453 and fixes tests --------- Signed-off-by: Ruiyang Wang <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…ay-project#38453) This reverts commit ef2a040. Signed-off-by: harborn <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…38459) Reverts ray-project#38453 and fixes tests --------- Signed-off-by: Ruiyang Wang <[email protected]> Signed-off-by: harborn <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…38459) Reverts ray-project#38453 and fixes tests --------- Signed-off-by: Ruiyang Wang <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ay-project#38453) This reverts commit ef2a040. Signed-off-by: e428265 <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…38459) Reverts ray-project#38453 and fixes tests --------- Signed-off-by: Ruiyang Wang <[email protected]> Signed-off-by: e428265 <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ay-project#38453) This reverts commit ef2a040. Signed-off-by: Victor <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…38459) Reverts ray-project#38453 and fixes tests --------- Signed-off-by: Ruiyang Wang <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #38243
It seems to reliably fail
test_autoscaler(and linting also failed which I fixed in #38446 -- but better to revert the original PR given the problems with test_autoscaler).