-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove grpcio from minimal dependency #38243
Conversation
add grpc deps to default and remove from minimal add DrainNode to python gcs_client, and remove grpc from autoscaler.py Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamp requirements change
…nt optional Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
…le tests Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
…nit tests. Signed-off-by: Ruiyang Wang <[email protected]>
Failed tests seem unrelated |
(Also, let's make sure to mention this to the release note. Please track the changes so that we can record them!) |
Looks like we need a doc approval. cc @angelinalg can you give us an approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc approval
This reverts commit ef2a040. Signed-off-by: Philipp Moritz <[email protected]>
Removes grpcio from ray dependency while adds it to ray[default] dependency. Removed use of grpc client: gcs_node_info_stub.DrainNode in autoscaler. Moved it into raylet.pyx. Removed use of grpc client: gcs_node_resources_stub.GetAllResourceUsage in autoscaler. Moved it into raylet.pyx. Removed use of grpc status code. Moved it into raylet.pyx. Removed Ray Client tests in test_runtime_env_ray_minimal.py --------- Signed-off-by: Ruiyang Wang <[email protected]> Signed-off-by: NripeshN <[email protected]>
…ay-project#38453) This reverts commit ef2a040. Signed-off-by: NripeshN <[email protected]>
Removes grpcio from ray dependency while adds it to ray[default] dependency. Removed use of grpc client: gcs_node_info_stub.DrainNode in autoscaler. Moved it into raylet.pyx. Removed use of grpc client: gcs_node_resources_stub.GetAllResourceUsage in autoscaler. Moved it into raylet.pyx. Removed use of grpc status code. Moved it into raylet.pyx. Removed Ray Client tests in test_runtime_env_ray_minimal.py --------- Signed-off-by: Ruiyang Wang <[email protected]> Signed-off-by: harborn <[email protected]>
…ay-project#38453) This reverts commit ef2a040. Signed-off-by: harborn <[email protected]>
Removes grpcio from ray dependency while adds it to ray[default] dependency. Removed use of grpc client: gcs_node_info_stub.DrainNode in autoscaler. Moved it into raylet.pyx. Removed use of grpc client: gcs_node_resources_stub.GetAllResourceUsage in autoscaler. Moved it into raylet.pyx. Removed use of grpc status code. Moved it into raylet.pyx. Removed Ray Client tests in test_runtime_env_ray_minimal.py --------- Signed-off-by: Ruiyang Wang <[email protected]>
Removes grpcio from ray dependency while adds it to ray[default] dependency. Removed use of grpc client: gcs_node_info_stub.DrainNode in autoscaler. Moved it into raylet.pyx. Removed use of grpc client: gcs_node_resources_stub.GetAllResourceUsage in autoscaler. Moved it into raylet.pyx. Removed use of grpc status code. Moved it into raylet.pyx. Removed Ray Client tests in test_runtime_env_ray_minimal.py --------- Signed-off-by: Ruiyang Wang <[email protected]> Signed-off-by: e428265 <[email protected]>
…ay-project#38453) This reverts commit ef2a040. Signed-off-by: e428265 <[email protected]>
Removes grpcio from ray dependency while adds it to ray[default] dependency. Removed use of grpc client: gcs_node_info_stub.DrainNode in autoscaler. Moved it into raylet.pyx. Removed use of grpc client: gcs_node_resources_stub.GetAllResourceUsage in autoscaler. Moved it into raylet.pyx. Removed use of grpc status code. Moved it into raylet.pyx. Removed Ray Client tests in test_runtime_env_ray_minimal.py --------- Signed-off-by: Ruiyang Wang <[email protected]> Signed-off-by: Victor <[email protected]>
…ay-project#38453) This reverts commit ef2a040. Signed-off-by: Victor <[email protected]>
Removes grpcio from
ray
dependency while adds it toray[default]
dependency.Removed use of grpc client:
gcs_node_info_stub.DrainNode
in autoscaler. Moved it intoraylet.pyx
.Removed use of grpc client:
gcs_node_resources_stub.GetAllResourceUsage
in autoscaler. Moved it intoraylet.pyx
.Removed use of grpc status code. Moved it into
raylet.pyx
.Removed Ray Client tests in
test_runtime_env_ray_minimal.py