-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[requirements] Install with compiled requirements as constraints [build_base] #36983
Changes from 1 commit
0f18cce
99c8e4b
2ed7c75
e18ec73
dab5995
d88f126
1397c2e
d2c5a90
ec48911
8452351
e858eb6
f3f3d28
6ef9515
fff3935
bc2427a
bb2a99c
1ebd59b
25879d8
d0d70c4
79e0457
4cd074b
cd76a02
936c07f
e05e1cb
bc1eb80
698b1b0
9ac12e1
ab5c6e4
1831ca2
24ededf
fab40ef
c33d28b
bc52cbc
b67a724
b87ecbc
2fa5917
0feb3c8
39d21db
c252bcb
bc2cfe7
404cff1
88b742d
3a6a9ed
1a17fa7
864be29
e66581e
48d83b0
415d679
4ec7ff4
b31cbab
1f167b3
b186fcf
f1d46a4
b675fbc
5a223f4
334eff0
48be89f
f963e91
3866529
2ffbadb
e62f18e
8a382cf
7dff525
1f919d1
4a5417e
f0f879c
2355977
a77fdfb
c753039
0e7c60f
0b301ff
d683b4a
64cfa7e
1d5e0ab
a3abd5a
eadc1fe
9a66aed
f6ef8bf
6b20f07
83e3fd8
497dfaa
2d1922d
3324f69
4a654b9
8d9957a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
Signed-off-by: Kai Fricke <[email protected]>
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,4 @@ | ||
ARG DOCKER_IMAGE_BASE_TEST | ||
FROM $DOCKER_IMAGE_BASE_TEST | ||
|
||
# Move out of working dir /ray | ||
# Delete stale data | ||
krfricke marked this conversation as resolved.
Show resolved
Hide resolved
|
||
WORKDIR / | ||
RUN rm -rf /ray | ||
|
||
RUN mkdir /ray | ||
WORKDIR /ray | ||
|
||
# Copy new ray files | ||
COPY . . | ||
|
||
RUN RLLIB_TESTING=1 TRAIN_TESTING=1 TUNE_TESTING=1 ./ci/env/install-dependencies.sh |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,10 +16,14 @@ ENV CXX=clang++-12 | |
# Move out of working dir /ray | ||
# Delete stale data | ||
WORKDIR / | ||
# Preserve requirements_compiled.txt | ||
RUN mv /ray/python/requirements_compiled.txt /tmp/requirements_compiled.txt || true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't use constraints in arm64, yet, so this is to ensure compatibility There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could you make it explicit on checking on the HOSTTYPE or uname output? I worry that this will drop errors silently. |
||
RUN rm -rf /ray | ||
|
||
RUN mkdir /ray | ||
WORKDIR /ray | ||
RUN mv /tmp/requirements_compiled.txt /ray/python/requirements_compiled.txt || true | ||
|
||
|
||
# Below should be re-run each time | ||
COPY . . | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we compiling dependencies on the fly? If so, perhaps we should compile them offline and check in the repo. That will keep the infra resistant from random updates from the internet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's been some discussion around this (e.g. here). In some sense we want to catch some of those updates to make sure
ray[all]
does not breakThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, 100% agree that requirements_compiled.txt need to be updated regularly. My suggestion is to capture those upgrades explicitly through a code change though. For example, we have have a bot to compile that list once a day and commit the change as a PR, or just a as DevProd oncall we can compile this list once a day. Many CI/CD tools such as blocking and bisect can only work soundly based on the assumptions that any bugs will be captured through a code change.