Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[requirements] Install with compiled requirements as constraints [build_base] #36983

Merged
merged 85 commits into from
Jul 14, 2023

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Jun 30, 2023

Why are these changes needed?

Following up from #36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Kai Fricke added 30 commits June 26, 2023 10:42
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
@krfricke krfricke merged commit 0da6a98 into ray-project:master Jul 14, 2023
116 of 122 checks passed
@krfricke krfricke deleted the requirements/tiers-constraint branch July 14, 2023 20:50
krfricke added a commit to krfricke/ray that referenced this pull request Jul 14, 2023
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <[email protected]>
pcmoritz added a commit that referenced this pull request Jul 15, 2023
krfricke added a commit that referenced this pull request Jul 16, 2023
krfricke pushed a commit that referenced this pull request Jul 16, 2023
krfricke added a commit that referenced this pull request Jul 17, 2023
krfricke added a commit to krfricke/ray that referenced this pull request Jul 18, 2023
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <[email protected]>
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 24, 2023
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <[email protected]>
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 24, 2023
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 24, 2023
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <[email protected]>
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: NripeshN <[email protected]>
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: harborn <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: e428265 <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Victor <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants