Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependencies] Remove urllib3 dependency #36609

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[Dependencies] Remove urllib3 dependency #36609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove urllib3 dependency 
Signed-off-by: Archit Kulkarni <[email protected]>
  • Loading branch information
@architkulkarni
architkulkarni committed Jun 20, 2023
commit b3fe543967d7ce1cb7c42a89fffa7595978b1f86
6 changes: 0 additions & 6 deletions python/ray/autoscaler/_private/autoscaler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,6 @@
)
from ray.core.generated import gcs_service_pb2, gcs_service_pb2_grpc

try:
from urllib3.exceptions import MaxRetryError
except ImportError:
MaxRetryError = None


logger = logging.getLogger(__name__)

# Status of a node e.g. "up-to-date", see ray/autoscaler/tags.py
Expand Down
1 change: 0 additions & 1 deletion python/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ colorful
pyyaml
rich
gpustat>=1.0.0
urllib3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is still a urllib3 in requrements-doc.txt ?

Copy link
Contributor Author

@architkulkarni architkulkarni Jun 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's for developers for the docs build, it won't get installed by pip install "ray[all]". It's possible that it can also be removed

opentelemetry-sdk
fastapi
virtualenv<20.21.1,>=20.0.24
Expand Down
1 change: 0 additions & 1 deletion python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,6 @@ def get_packages(self):
],
"serve": ["uvicorn", "requests", "starlette", "fastapi", "aiorwlock"],
"tune": ["pandas", "tensorboardX>=1.9", "requests", pyarrow_dep],
"k8s": ["urllib3"],
"observability": [
"opentelemetry-api",
"opentelemetry-sdk",
Expand Down
Loading