Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependencies] Remove urllib3 dependency #36609

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[Dependencies] Remove urllib3 dependency #36609

merged 1 commit into from
Jun 22, 2023

Conversation

architkulkarni
Copy link
Contributor

Why are these changes needed?

urllib3 was listed as a dependency under ray[k8s] (and therefore ray[all]), but upon inspection it seems it isn't actually used.

This PR removes urllib3 from the dependencies.

In this PR, ray[k8s] is also removed since urllib3 was the only dependency there. I confirmed manually that pip install ray[doesnotexist] doesn't fail, so this PR won't break any existing user scripts that contain pip install ray[k8s].

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni
Remove urllib3 dependency
b3fe543 
Signed-off-by: Archit Kulkarni <[email protected]>
@architkulkarni architkulkarni marked this pull request as ready for review June 20, 2023 20:01
pcmoritz
pcmoritz approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing this! :)

@architkulkarni
Copy link
Contributor Author

Failures are all unrelated:
tune_bohb unrelated and flaky on master
tune test_client unrelated and flaky on master
test_http_job_server.py::test_ray_tune_basic unrelated and broken on master
book-documentation broken on master

@architkulkarni architkulkarni added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 20, 2023
aslonnie
aslonnie reviewed Jun 21, 2023
View reviewed changes
python/requirements.txt
@@ -40,7 +40,6 @@ colorful
pyyaml
rich
gpustat>=1.0.0
urllib3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is still a urllib3 in requrements-doc.txt ?

Copy link
Contributor Author

@architkulkarni architkulkarni Jun 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's for developers for the docs build, it won't get installed by pip install "ray[all]". It's possible that it can also be removed

@pcmoritz pcmoritz merged commit 6a77bf7 into ray-project:master Jun 22, 2023
95 of 100 checks passed
akshay-anyscale pushed a commit that referenced this pull request Jun 24, 2023
@architkulkarni @akshay-anyscale
Remove urllib3 dependency (#36609)
afb9592 
urllib3 was listed as a dependency under ray[k8s] (and therefore ray[all]), but upon inspection it seems it isn't actually used.

This PR removes urllib3 from the dependencies.

In this PR, ray[k8s] is also removed since urllib3 was the only dependency there. I confirmed manually that pip install ray[doesnotexist] doesn't fail, so this PR won't break any existing user scripts that contain pip install ray[k8s].

Signed-off-by: Archit Kulkarni <[email protected]>
@pcmoritz pcmoritz mentioned this pull request Jun 30, 2023
Closed
SongGuyang pushed a commit to alipay/ant-ray that referenced this pull request Jul 12, 2023
@architkulkarni @SongGuyang
Remove urllib3 dependency (ray-project#36609)
6e871ea 
urllib3 was listed as a dependency under ray[k8s] (and therefore ray[all]), but upon inspection it seems it isn't actually used.

This PR removes urllib3 from the dependencies.

In this PR, ray[k8s] is also removed since urllib3 was the only dependency there. I confirmed manually that pip install ray[doesnotexist] doesn't fail, so this PR won't break any existing user scripts that contain pip install ray[k8s].

Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: 久龙 <[email protected]>
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
@architkulkarni @harborn
Remove urllib3 dependency (ray-project#36609)
8a257da 
urllib3 was listed as a dependency under ray[k8s] (and therefore ray[all]), but upon inspection it seems it isn't actually used.

This PR removes urllib3 from the dependencies.

In this PR, ray[k8s] is also removed since urllib3 was the only dependency there. I confirmed manually that pip install ray[doesnotexist] doesn't fail, so this PR won't break any existing user scripts that contain pip install ray[k8s].

Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: harborn <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
@architkulkarni @harborn
Remove urllib3 dependency (ray-project#36609)
a2fd238 
urllib3 was listed as a dependency under ray[k8s] (and therefore ray[all]), but upon inspection it seems it isn't actually used.

This PR removes urllib3 from the dependencies.

In this PR, ray[k8s] is also removed since urllib3 was the only dependency there. I confirmed manually that pip install ray[doesnotexist] doesn't fail, so this PR won't break any existing user scripts that contain pip install ray[k8s].

Signed-off-by: Archit Kulkarni <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@architkulkarni @arvind-chandra
Remove urllib3 dependency (ray-project#36609)
1e5013b 
urllib3 was listed as a dependency under ray[k8s] (and therefore ray[all]), but upon inspection it seems it isn't actually used.

This PR removes urllib3 from the dependencies.

In this PR, ray[k8s] is also removed since urllib3 was the only dependency there. I confirmed manually that pip install ray[doesnotexist] doesn't fail, so this PR won't break any existing user scripts that contain pip install ray[k8s].

Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslonnie aslonnie aslonnie left review comments

@pcmoritz pcmoritz pcmoritz approved these changes

@edoakes edoakes edoakes approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw is a code owner

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman

Assignees

@richardliaw richardliaw

@aslonnie aslonnie

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@architkulkarni @pcmoritz @edoakes @aslonnie @richardliaw