update

python/ray/autoscaler/v2/instance_manager/node_provider.py

@@ -37,7 +37,7 @@ def get_non_terminated_nodes(
  pass
 
  @abstractmethod
- def get_nodes_by_cloud_id(
+ def get_nodes_by_cloud_instance_id(
  self,
  cloud_instance_ids: List[str],
  ) -> Dict[str, Instance]:
@@ -103,9 +103,9 @@ def is_readonly(self) -> bool:
 
  def get_non_terminated_nodes(self):
  clould_instance_ids = self._provider.non_terminated_nodes()
- return self.get_nodes_by_cloud_id(clould_instance_ids)
+ return self.get_nodes_by_cloud_instance_id(clould_instance_ids)
 
- def get_nodes_by_cloud_id(
+ def get_nodes_by_cloud_instance_id(
  self,
  cloud_instance_ids: List[str],
  ) -> Dict[str, Instance]:

python/ray/autoscaler/v2/tests/test_node_provider.py

@@ -21,7 +21,7 @@ class NodeProviderTest(unittest.TestCase):
  def setUp(self):
  self.base_provider = MockProvider()
  self.node_launcher = BaseNodeLauncher(
- self.provider,
+ self.base_provider,
  ConcurrentCounter(),
  EventSummarizer(),
  NodeProviderAvailabilityTracker(),
@@ -33,5 +33,18 @@ def setUp(self):
  self.base_provider, self.node_launcher, self.instance_config_provider
  )
 
- def tearDown(self):
- pass
+ def test_create_nodes(self):
+ self.node_provider.create_nodes("test", 1)
+ self.assertEqual(len(self.base_provider.mock_nodes), 1)
+
+ def test_terminate_nodes(self):
+ self.node_provider.create_nodes("test", 1)
+ self.assertEqual(len(self.base_provider.mock_nodes), 1)
+
+ def test_get_nodes(self):
+ self.node_provider.create_nodes("test", 1)
+ self.assertEqual(len(self.base_provider.mock_nodes), 1)
+
+ def get_nodes_by_cloud_instance_id(self):
+ self.node_provider.create_nodes("test", 1)
+ self.assertEqual(len(self.base_provider.mock_nodes), 1)