Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoscaler v2] add test for node provider #35593

Merged
merged 29 commits into from
May 26, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented May 22, 2023

Why are these changes needed?

add tests for node_provider v2 and refactor the mock code

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 changed the title [autoscaler v2] add test for node provider [autoscaler v2][wip] add test for node provider May 22, 2023
@scv119 scv119 marked this pull request as ready for review May 22, 2023 22:09
@scv119 scv119 changed the title [autoscaler v2][wip] add test for node provider [autoscaler v2] add test for node provider May 22, 2023
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rickyyx
Copy link
Contributor

rickyyx commented May 23, 2023

Some test failures look relevant.

@rickyyx rickyyx added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label May 23, 2023
@@ -1902,6 +1899,29 @@ def has_no_words(string, words):
return not any(search_words(string, words))


def find_available_port(start, end, port_num=1):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def get_current_unused_port():
"""
Returns a port number that is not currently in use.
This is useful for testing when we need to bind to a port but don't
care which one.
Returns:
A port number that is not currently in use. (Note that this port
might become used by the time you try to bind to it.)
"""
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
# Bind the socket to a local address with a random port number
sock.bind(("localhost", 0))
port = sock.getsockname()[1]
sock.close()
return port

FYI

@scv119 scv119 added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels May 26, 2023
@scv119 scv119 merged commit ce16a2e into ray-project:master May 26, 2023
1 of 2 checks passed
scv119 added a commit to scv119/ray that referenced this pull request Jun 16, 2023
Why are these changes needed?
add tests for node_provider v2 and refactor the mock code
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Why are these changes needed?
add tests for node_provider v2 and refactor the mock code

Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants