-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[autoscaler v2] add test for node provider #35593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7354ac
to
fdeda1e
Compare
fdeda1e
to
77b9699
Compare
rickyyx
reviewed
May 22, 2023
rickyyx
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Some test failures look relevant. |
Co-authored-by: Ricky Xu <[email protected]> Signed-off-by: Chen Shen <[email protected]>
Co-authored-by: Ricky Xu <[email protected]> Signed-off-by: Chen Shen <[email protected]>
Signed-off-by: Chen Shen <[email protected]>
rickyyx
approved these changes
May 26, 2023
python/ray/_private/test_utils.py
Outdated
@@ -1902,6 +1899,29 @@ def has_no_words(string, words): | |||
return not any(search_words(string, words)) | |||
|
|||
|
|||
def find_available_port(start, end, port_num=1): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ray/python/ray/_private/test_utils.py
Lines 1847 to 1865 in ce7764b
def get_current_unused_port(): | |
""" | |
Returns a port number that is not currently in use. | |
This is useful for testing when we need to bind to a port but don't | |
care which one. | |
Returns: | |
A port number that is not currently in use. (Note that this port | |
might become used by the time you try to bind to it.) | |
""" | |
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) | |
# Bind the socket to a local address with a random port number | |
sock.bind(("localhost", 0)) | |
port = sock.getsockname()[1] | |
sock.close() | |
return port |
FYI
scv119
added a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
Why are these changes needed? add tests for node_provider v2 and refactor the mock code
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Why are these changes needed? add tests for node_provider v2 and refactor the mock code Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
add tests for node_provider v2 and refactor the mock code
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.