Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] [developer] clarify M1 installation instructions #34505

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

angelinalg
Copy link
Contributor

Why are these changes needed?

A few folks have been confused by the order of the installation instructions for M1, so adding some clarifying language. While I was at it, I made minor improvements to some language in nearby paragraphs.

Related issue number

None

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

A few folks have been confused by the order of the installation instructions for M1, so adding some clarifying language. While I was at it, I made minor improvements to some language in nearby paragraphs.

Signed-off-by: angelinalg <[email protected]>
@angelinalg angelinalg requested a review from a team as a code owner April 17, 2023 23:31
The double quotes might've broken the build.

Signed-off-by: angelinalg <[email protected]>
@pcmoritz pcmoritz merged commit d1c7351 into master Apr 20, 2023
@pcmoritz pcmoritz deleted the angelinalg-patch-2 branch April 20, 2023 02:37
@angelinalg angelinalg changed the title clarify M1 installation instructions [docs] clarify M1 installation instructions Apr 20, 2023
@zhe-thoughts
Copy link
Collaborator

Approved for picking into 2.4.0

@angelinalg angelinalg changed the title [docs] clarify M1 installation instructions [docs] [developer] clarify M1 installation instructions Apr 21, 2023
jjyao pushed a commit that referenced this pull request Apr 21, 2023
A few folks have been confused by the order of the installation instructions for M1, so adding some clarifying language. While I was at it, I made minor improvements to some language in nearby paragraphs.
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
A few folks have been confused by the order of the installation instructions for M1, so adding some clarifying language. While I was at it, I made minor improvements to some language in nearby paragraphs.

Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
A few folks have been confused by the order of the installation instructions for M1, so adding some clarifying language. While I was at it, I made minor improvements to some language in nearby paragraphs.

Signed-off-by: Jack He <[email protected]>
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
A few folks have been confused by the order of the installation instructions for M1, so adding some clarifying language. While I was at it, I made minor improvements to some language in nearby paragraphs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants