[docs] [tune] replace tune.report with session.report #34435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address: #34434 Signed-off-by: angelinalg <[email protected]>
matthewdeng
reviewed
Apr 17, 2023
| @@ -105,7 +105,7 @@ def train_mnist(config): | |||
| acc = test(model, test_loader) | |||
|
|
|||
| # Send the current training result back to Tune | |||
| tune.report(mean_accuracy=acc) | |||
| session.report(mean_accuracy=acc) | |||
There was a problem hiding this comment.
Will need to also include the proper import at the top:
from ray.air import session
Does that look right, @matthewdeng? BTW, thanks for catching that. Signed-off-by: angelinalg <[email protected]>
matthewdeng
approved these changes
Apr 18, 2023
|
@matthewdeng I've never merged a PR for this directory before. Are you able to merge it? Or should I rebase and try to get the tests to pass, first? |
angelinalg
changed the title
|
@richardliaw can you merge? If somehow this breaks master I will take full responsibility. |
famous last words :-D
I'll file a fix |
8 tasks
krfricke
added a commit
that referenced
this pull request
Apr 21, 2023
One line fix for bug introduced in #34435 Signed-off-by: Kai Fricke <[email protected]>
|
Lol sigh, thanks @krfricke 😅 |
angelinalg
changed the title
angelinalg
changed the title
jjyao
pushed a commit
that referenced
this pull request
Apr 21, 2023
jjyao
pushed a commit
that referenced
this pull request
Apr 21, 2023
One line fix for bug introduced in #34435 Signed-off-by: Kai Fricke <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Signed-off-by: elliottower <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
One line fix for bug introduced in ray-project#34435 Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
Signed-off-by: Jack He <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
One line fix for bug introduced in ray-project#34435 Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: Jack He <[email protected]>
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
One line fix for bug introduced in ray-project#34435 Signed-off-by: Kai Fricke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To address CSAT reported feedback that example was using an outdated API (tune.report) which is replaced with session.report.
Related issue number
(#34434)
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.