Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ds.lazy() since Dataset is lazy already #33812

Merged
merged 7 commits into from
Mar 29, 2023
Merged

Deprecate ds.lazy() since Dataset is lazy already #33812

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
925a247
Revert "[Datasets] Revert "Enable streaming executor by default (#324…
jianoaix Mar 22, 2023
b33ae23
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Mar 23, 2023
4ef5d35
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Mar 24, 2023
e6dcd6e
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Mar 24, 2023
482e9dc
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Mar 28, 2023
5eb32ee
Deprecate ds.lazy() since Dataset is lazy already
jianoaix Mar 28, 2023
95a9ce4
Feedback
jianoaix Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/ray/data/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4131,6 +4131,10 @@ def get_internal_block_refs(self) -> List[ObjectRef[Block]]:
self._synchronize_progress_bar()
return blocks

@Deprecated(
message="Dataset is lazy by default, so this conversion call is no longer "
"needed and this API will be removed in future release"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits (grammar):

  • "Datasets is lazy ..."
  • "in a future release"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (the Dataset here is referring to this class not the library we provide, so incline to keep it as Dataset).

)
def lazy(self) -> "Dataset[T]":
"""Enable lazy evaluation.

Expand Down