Deprecate ds.lazy() since Dataset is lazy already #33812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project#32493)" (ray-project#33485)" This reverts commit 5c79954.
jianoaix
requested review from
ericl,
scv119,
clarkzinzow and
jjyao
as code owners
c21
approved these changes
Mar 28, 2023
zhe-thoughts
approved these changes
Mar 28, 2023
python/ray/data/dataset.py
Outdated
| @@ -4131,6 +4131,10 @@ def get_internal_block_refs(self) -> List[ObjectRef[Block]]: | |||
| self._synchronize_progress_bar() | |||
| return blocks | |||
|
|
|||
| @Deprecated( | |||
| message="Dataset is lazy by default, so this conversion call is no longer " | |||
| "needed and this API will be removed in future release" | |||
There was a problem hiding this comment.
Nits (grammar):
- "Datasets is lazy ..."
- "in a future release"
There was a problem hiding this comment.
Done (the Dataset here is referring to this class not the library we provide, so incline to keep it as Dataset).
c21
added
the
tests-ok
|
LGTM, feel free to merge |
joncarter1
pushed a commit
to joncarter1/ray
that referenced
this pull request
Apr 2, 2023
ray-project#31639 Signed-off-by: Jonathan Carter <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
ray-project#31639 Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
ray-project#31639 Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#31639
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.