Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "[Doc] [Jobs] Document JobDetails, JobType and DriverInfo"" #30500

Merged
merged 8 commits into from
Nov 29, 2022
Merged

Revert "Revert "[Doc] [Jobs] Document JobDetails, JobType and DriverInfo"" #30500

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
da84285
Revert "Revert "[Doc] [Jobs] Document `JobDetails`, `JobType` and `Dr…
architkulkarni Nov 19, 2022
4f390e4
Install "ray[default]" for conda tests
architkulkarni Nov 19, 2022
f1013ce
Lint
architkulkarni Nov 19, 2022
28903b9
Fix typo
architkulkarni Nov 19, 2022
8e64ac5
Lint
architkulkarni Nov 19, 2022
1326f81
Merge branch 'master' of https://github.com/ray-project/ray into reve…
architkulkarni Nov 21, 2022
88f734d
Add quotes around "ray[default]"
architkulkarni Nov 21, 2022
fb9ddc8
Download -> install this module
architkulkarni Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint 
Signed-off-by: Archit Kulkarni <[email protected]>
  • Loading branch information
@architkulkarni
architkulkarni committed Nov 19, 2022
commit 8e64ac5cc5f04c54153e1a130788a2f4be1c9c22
4 changes: 1 addition & 3 deletions dashboard/modules/job/tests/test_http_job_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,7 @@ def test_submit_job(job_sdk_client, runtime_env_option, monkeypatch):
runtime_env=runtime_env_option["runtime_env"],
)

wait_for_condition(
_check_job_succeeded, client=client, job_id=job_id, timeout=60
)
wait_for_condition(_check_job_succeeded, client=client, job_id=job_id, timeout=60)

logs = client.get_job_logs(job_id)
assert runtime_env_option["expected_logs"] in logs
Expand Down