-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "[Doc] [Jobs] Document JobDetails
, JobType
and DriverInfo
""
#30500
Merged
architkulkarni
merged 8 commits into
master
from
revert-30499-revert-30441-doc-job-details
Nov 29, 2022
Merged
Revert "Revert "[Doc] [Jobs] Document JobDetails
, JobType
and DriverInfo
""
#30500
architkulkarni
merged 8 commits into
master
from
revert-30499-revert-30441-doc-job-details
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
…rt-30499-revert-30441-doc-job-details Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
simon-mo
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamp
sihanwang41
approved these changes
Nov 21, 2022
dmatrix
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a minor or nit suggestion. Otherwise, LGTM
Signed-off-by: Archit Kulkarni <[email protected]>
|
architkulkarni
added a commit
to architkulkarni/ray
that referenced
this pull request
Nov 30, 2022
…iverInfo`"" (ray-project#30500) Reverts ray-project#30499. The reason this PR was originally reverted because it caused Jobs runtime env tests to fail, because runtime_env CI tests were installing "ray" into the runtime_env conda environment instead of "ray[default]", which is required for Jobs. This PR fixes this by installing "ray[default]" in runtime_env CI tests. Original PR description: The classes JobDetails, JobType and DriverInfo are exposed to the user because they are the return type of JobSubmissionClient.get_job_info, so we need to document them. This PR adds them to the API reference.
7 tasks
xwjiang2010
pushed a commit
that referenced
this pull request
Nov 30, 2022
…iverInfo`"" (#30500) (#30806) Reverts #30499. The reason this PR was originally reverted because it caused Jobs runtime env tests to fail, because runtime_env CI tests were installing "ray" into the runtime_env conda environment instead of "ray[default]", which is required for Jobs. This PR fixes this by installing "ray[default]" in runtime_env CI tests. Original PR description: The classes JobDetails, JobType and DriverInfo are exposed to the user because they are the return type of JobSubmissionClient.get_job_info, so we need to document them. This PR adds them to the API reference.
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…iverInfo`"" (ray-project#30500) Reverts ray-project#30499. The reason this PR was originally reverted because it caused Jobs runtime env tests to fail, because runtime_env CI tests were installing "ray" into the runtime_env conda environment instead of "ray[default]", which is required for Jobs. This PR fixes this by installing "ray[default]" in runtime_env CI tests. Original PR description: The classes JobDetails, JobType and DriverInfo are exposed to the user because they are the return type of JobSubmissionClient.get_job_info, so we need to document them. This PR adds them to the API reference. Signed-off-by: Weichen Xu <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…iverInfo`"" (ray-project#30500) Reverts ray-project#30499. The reason this PR was originally reverted because it caused Jobs runtime env tests to fail, because runtime_env CI tests were installing "ray" into the runtime_env conda environment instead of "ray[default]", which is required for Jobs. This PR fixes this by installing "ray[default]" in runtime_env CI tests. Original PR description: The classes JobDetails, JobType and DriverInfo are exposed to the user because they are the return type of JobSubmissionClient.get_job_info, so we need to document them. This PR adds them to the API reference. Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…iverInfo`"" (ray-project#30500) Reverts ray-project#30499. The reason this PR was originally reverted because it caused Jobs runtime env tests to fail, because runtime_env CI tests were installing "ray" into the runtime_env conda environment instead of "ray[default]", which is required for Jobs. This PR fixes this by installing "ray[default]" in runtime_env CI tests. Original PR description: The classes JobDetails, JobType and DriverInfo are exposed to the user because they are the return type of JobSubmissionClient.get_job_info, so we need to document them. This PR adds them to the API reference. Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30499. The reason this PR was originally reverted because it caused Jobs runtime env tests to fail, because runtime_env CI tests were installing
"ray"
into the runtime_env conda environment instead of"ray[default]"
, which is required for Jobs. This PR fixes this by installing"ray[default]"
in runtime_env CI tests.Original PR description:
The classes
JobDetails
,JobType
andDriverInfo
are exposed to the user because they are the return type ofJobSubmissionClient.get_job_info
, so we need to document them.This PR adds them to the API reference.