Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime env] [CI] Skip flaky test_runtime_env_working_dir_2 tests on mac #27799

Merged
merged 1 commit into from
Aug 12, 2022
Merged

[runtime env] [CI] Skip flaky test_runtime_env_working_dir_2 tests on mac #27799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Skip flaky tests on mac
  • Loading branch information
@architkulkarni
architkulkarni committed Aug 11, 2022
commit cdb8afb40ebafb667f3df5bbc9559f04d3489dcc
6 changes: 6 additions & 0 deletions python/ray/tests/test_runtime_env_working_dir_2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ def test_large_dir_upload_message(start_cluster, option):
assert "warning" not in output.lower()


# TODO(architkulkarni): Deflake and reenable this test.
@pytest.mark.skipif(sys.platform == "darwin", reason="Flaky on Mac. Issue #27562")
@pytest.mark.skipif(sys.platform != "darwin", reason="Package exceeds max size.")
def test_ray_worker_dev_flow(start_cluster):
cluster, address = start_cluster
Expand Down Expand Up @@ -233,6 +235,8 @@ def training_function(config):
assert ray.get(test_tune.remote()) != serve.__path__[0]


# TODO(architkulkarni): Deflake and reenable this test.
@pytest.mark.skipif(sys.platform == "darwin", reason="Flaky on Mac. Issue #27562")
@pytest.mark.skipif(sys.platform == "win32", reason="Fail to create temp dir.")
@pytest.mark.parametrize("option", ["working_dir", "py_modules"])
@pytest.mark.parametrize("source", [S3_PACKAGE_URI, lazy_fixture("tmp_working_dir")])
Expand Down Expand Up @@ -325,6 +329,8 @@ def check(self):
],
indirect=True,
)
# TODO(architkulkarni): Deflake and reenable this test.
@pytest.mark.skipif(sys.platform == "darwin", reason="Flaky on Mac. Issue #27562")
@pytest.mark.skipif(sys.platform == "win32", reason="Fail to create temp dir.")
@pytest.mark.parametrize("option", ["working_dir", "py_modules"])
def test_task_level_gc(runtime_env_disable_URI_cache, ray_start_cluster, option):
Expand Down