Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime env] [CI] Skip flaky test_runtime_env_working_dir_2 tests on mac #27799

Merged

Conversation

architkulkarni
Copy link
Contributor

Why are these changes needed?

Some tests in test_runtime_env_working_dir_2 are passing on Linux but flaky on Mac. This test skips them on Mac to fix CI. The underlying issue #27562 will remain open until we fix the root cause and reenable them on Mac.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni architkulkarni changed the title [CI] Skip flaky test_runtime_env_working_dir_2 tests on mac [runtime env] [CI] Skip flaky test_runtime_env_working_dir_2 tests on mac Aug 11, 2022
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp

@architkulkarni
Copy link
Contributor Author

Mac tests:test_actor_failures flaky on master and unrelated
Docs linkcheck broken on master and unrelated
RLlib tune_lin_ucb_train_recsim_env flaky and unrelated
rllib:test_memory_leak_ppo flaky and unrelated
test_tune_restore and test_cluster flaky and unrelated
Windows:
serve:tutorial_rllib broken on master and unrelated
tests:test_client_library_integration, test_tensorflow broken and unrelated

@architkulkarni architkulkarni added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 11, 2022
@simon-mo simon-mo merged commit 6c45625 into ray-project:master Aug 12, 2022
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants