Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix tracing bug when actors are defined before connecting to … #16120

Merged
merged 1 commit into from
May 27, 2021

Conversation

ericl
Copy link
Contributor

@ericl ericl commented May 27, 2021

…cluster (#16069)"

This reverts commit 6c1ea66.




File "/ray/python/ray/util/tracing/tracing_helper.py", line 279, in _function_with_tracing
  | return function(*args, **kwargs)
  | File "/tmp/ray_cross_language_test/test_cross_language_invocation.py", line 56, in py_func_call_java_actor
  | java_actor = c.remote(b"Counter")
  | File "/ray/python/ray/actor.py", line 418, in remote
  | return self._remote(args=args, kwargs=kwargs)
  | File "/ray/python/ray/util/tracing/tracing_helper.py", line 317, in _invocation_actor_class_remote_span
  | return method(self, args, kwargs, *_args, **_kwargs)
  | File "/ray/python/ray/actor.py", line 698, in _remote
  | creation_args = cross_language.format_args(worker, args, kwargs)
  | File "/ray/python/ray/cross_language.py", line 29, in format_args
  | raise TypeError("Cross language remote functions "
  | TypeError: Cross language remote functions does not support kwargs.
 

<br class="Apple-interchange-newline">

@richardliaw richardliaw merged commit 9c73591 into ray-project:master May 27, 2021
@richardliaw richardliaw deleted the revert-java branch May 27, 2021 18:50
@simon-mo
Copy link
Contributor

hmmm this is another determine-tests-to-run bug. Java tests were not ran in that PR.

@simon-mo
Copy link
Contributor

simon-mo commented May 27, 2021

image

simon-mo added a commit that referenced this pull request May 27, 2021
simon-mo added a commit to simon-mo/ray that referenced this pull request Jun 9, 2021
We recently had two master breakages due to determine_tests_to_run
script bug.
ray-project#16120
ray-project#15981

This PR fix both of them.
ericl pushed a commit that referenced this pull request Jun 9, 2021
We recently had two master breakages due to determine_tests_to_run
script bug.
#16120
#15981

This PR fix both of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants