Fix tracing bug when actors are defined before connecting to cluster #16069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
approved these changes
May 26, 2021
simon-mo
approved these changes
May 27, 2021
ericl
added a commit
to ericl/ray
that referenced
this pull request
May 27, 2021
…cluster (ray-project#16069)" This reverts commit 6c1ea66.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Actors that were defined before connecting to or starting a Ray cluster were not being traced correctly.
Safeguard retrieval of task/actor ID.
Update tracing docs.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.