[rllib] Basic regression tests on CartPole #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should outline on #1530 perhaps what we want the full regression suite to look like. |
|
Test PASSed. |
richardliaw
reviewed
Feb 28, 2018
| for test in glob.glob("regression_tests/*.yaml"): | ||
| config = yaml.load(open(test).read()) | ||
| for trial in config.values(): | ||
| trial["stop"]["training_iteration"] = 1 |
| @@ -157,8 +157,9 @@ def _step(self, global_timestep): | |||
| return ret | |||
|
|
|||
| def stats(self): | |||
| mean_100ep_reward = round(np.mean(self.episode_rewards[-101:-1]), 5) | |||
| mean_100ep_length = round(np.mean(self.episode_lengths[-101:-1]), 5) | |||
| n = self.config["smoothing_num_episodes"] + 1 | |||
There was a problem hiding this comment.
would be good to add a note that there's some weird thing with the last entry and we should fix
richardliaw
approved these changes
Feb 28, 2018
|
Test PASSed. |
|
Test PASSed. |
|
Test hang seems unrelated, merging. |
royf
added a commit
to royf/ray
that referenced
this pull request
Apr 22, 2018
* 'master' of https://github.com/royf/ray-private: [rllib] Basic regression tests on CartPole (ray-project#1608) [autoscaler] [tune] More doc fixes (ray-project#1560) [tune] Hyperband Max Iter Fix (ray-project#1620)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is first cut at pre-release regression tests, currently just CartPole.
Related issue number
#1530