Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoscaler] [tune] More doc fixes #1560

Merged
merged 21 commits into from
Mar 3, 2018
Merged

[autoscaler] [tune] More doc fixes #1560

merged 21 commits into from
Mar 3, 2018

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Feb 18, 2018

What do these changes do?

Related issue number

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3831/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3832/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3833/
Test PASSed.

@richardliaw
Copy link
Contributor

@vlad17 didn't you also need dpkg configure -a after sudo pkill -9?

@vlad17
Copy link

vlad17 commented Feb 19, 2018

@richardliaw yeah

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3871/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3887/
Test PASSed.

@@ -80,6 +81,9 @@ file_mounts: {

# List of shell commands to run to set up nodes.
setup_commands:
# Consider uncommenting these if you run into dpkg locking issues
# - sudo pkill -9 apt-get || true
# - sudo pkill -9 dpkg || true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not also
- sudo dpkg --configure -a here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3951/
Test PASSed.

@@ -31,7 +31,7 @@ To run connect to applications running on the cluster (e.g. Jupyter notebook) us

.. code-block:: bash

$ ssh -L 8899:localhost:8899 -i <key> <user>@<addr> jupyter notebook --port=8899
$ ssh -L 8899:localhost:8899 -i <key> <user>@<addr> 'source ~/anaconda3/bin/activate tensorflow_p36 && jupyter notebook --port=8899`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work? the example.yaml doesn't install in this env right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I changed this to install ray into tensorflow_p36, and updated the doc accordingly.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3966/
Test PASSed.

@richardliaw
Copy link
Contributor

@ericl sphinx lint failed

@ericl ericl changed the title [autoscaler] More doc fixes [autoscaler] [tune] More doc fixes Feb 28, 2018
@ericl
Copy link
Contributor Author

ericl commented Feb 28, 2018

Also added a full mnist example for hyperband (requested by user).

@richardliaw richardliaw self-assigned this Feb 28, 2018
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4049/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4050/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4051/
Test PASSed.

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; would probably be nice to put a smoke test in for the example

@ericl
Copy link
Contributor Author

ericl commented Mar 2, 2018

Good though, added smoke test

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4074/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4075/
Test PASSed.

@ericl
Copy link
Contributor Author

ericl commented Mar 3, 2018

Test hang looks unrelated, merging

@ericl ericl merged commit 80d7def into ray-project:master Mar 3, 2018
royf added a commit to royf/ray that referenced this pull request Apr 22, 2018
* 'master' of https://github.com/royf/ray-private:
  [rllib] Basic regression tests on CartPole (ray-project#1608)
  [autoscaler] [tune] More doc fixes (ray-project#1560)
  [tune] Hyperband Max Iter Fix (ray-project#1620)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants