Skip failing tests on Windows. #10139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Aug 17, 2020
rkooo567
reviewed
Aug 17, 2020
| @@ -59,7 +59,7 @@ def cpu_task(): | |||
| @pytest.mark.skipif( | |||
| pytest_timeout is None, | |||
| reason="Timeout package not installed; skipping test that may hang.") | |||
| @pytest.mark.timeout(20) | |||
| @pytest.mark.timeout(120) | |||
There was a problem hiding this comment.
Why do we have really long timeout here?
There was a problem hiding this comment.
It looked like the test was timing out since it starts and stops a lot of processes.
robertnishihara
commented
Aug 18, 2020
| @@ -7,12 +7,14 @@ | |||
| TYPING_TEST_DIRS = os.path.join(os.path.dirname(__file__), "typing_files") | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.") | |||
There was a problem hiding this comment.
@pcmoritz note that typing seems to be failing on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.