Skip to content

Commit

Permalink
Skip failing tests on Windows. (#10139)
Browse files Browse the repository at this point in the history
  • Loading branch information
robertnishihara committed Aug 18, 2020
1 parent 927a073 commit d454189
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 3 deletions.
1 change: 1 addition & 0 deletions python/ray/tests/test_actor_resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ def echo(self, value):
@pytest.mark.skipif(
os.environ.get("RAY_USE_NEW_GCS") == "on",
reason="Failing with new GCS API on Linux.")
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_actor_gpus(ray_start_cluster):
cluster = ray_start_cluster
num_nodes = 3
Expand Down
6 changes: 4 additions & 2 deletions python/ray/tests/test_autoscaler_yaml.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import jsonschema
import os
import sys
import tempfile
import unittest
import yaml
import urllib
import tempfile
import yaml

from ray.autoscaler.util import prepare_config, validate_config
from ray.test_utils import recursive_fnmatch
Expand Down Expand Up @@ -51,6 +52,7 @@ def _test_invalid_config(self, config_path):
except jsonschema.ValidationError:
pass

@unittest.skipIf(sys.platform == "win32", "Failing on Windows.")
def testInvalidConfig(self):
self._test_invalid_config(
os.path.join("tests", "additional_property.yaml"))
Expand Down
2 changes: 1 addition & 1 deletion python/ray/tests/test_global_state.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def cpu_task():
@pytest.mark.skipif(
pytest_timeout is None,
reason="Timeout package not installed; skipping test that may hang.")
@pytest.mark.timeout(20)
@pytest.mark.timeout(120)
def test_add_remove_cluster_resources(ray_start_cluster_head):
"""Tests that Global State API is consistent with actual cluster."""
cluster = ray_start_cluster_head
Expand Down
1 change: 1 addition & 0 deletions python/ray/tests/test_output.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from ray.test_utils import run_string_as_driver_nonblocking


@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_worker_stdout():
script = """
import ray
Expand Down
2 changes: 2 additions & 0 deletions python/ray/tests/test_typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@
TYPING_TEST_DIRS = os.path.join(os.path.dirname(__file__), "typing_files")


@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_typing_good():
script = os.path.join(TYPING_TEST_DIRS, "check_typing_good.py")
msg, _, status_code = mypy_api.run([script])
assert status_code == 0, msg


@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_typing_bad():
script = os.path.join(TYPING_TEST_DIRS, "check_typing_bad.py")
msg, _, status_code = mypy_api.run([script])
Expand Down

0 comments on commit d454189

Please sign in to comment.