Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing clone overrides on derived aggregations #6898

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Fix missing clone overrides on derived aggregations #6898

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e21c4bf
Fix missing clone overrides on derived aggregations
jlowe Dec 3, 2020
40db418
changelog
jlowe Dec 3, 2020
55d1e14
Merge branch 'branch-0.17' into fix-agg-clone
jlowe Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@
- PR #6869 Avoid dependency resolution failure in latest version of pip by explicitly specifying versions for dask and distributed
- PR #6806 Force install of local conda artifacts
- PR #6887 Fix typo and `0-d` numpy array handling in binary operation
- PR #6898 Fix missing clone overrides on derived aggregations


# cuDF 0.16.0 (21 Oct 2020)

Expand Down
15 changes: 15 additions & 0 deletions cpp/include/cudf/detail/aggregation/aggregation.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ struct min_aggregation final : aggregation {
return {this->kind};
}
void finalize(aggregation_finalizer& finalizer) override { finalizer.visit(*this); }

std::unique_ptr<aggregation> clone() const override
{
return std::make_unique<min_aggregation>(*this);
}
};

/**
Expand All @@ -77,6 +82,11 @@ struct max_aggregation final : aggregation {
return {this->kind};
}
void finalize(aggregation_finalizer& finalizer) override { finalizer.visit(*this); }

std::unique_ptr<aggregation> clone() const override
{
return std::make_unique<max_aggregation>(*this);
}
};

/**
Expand Down Expand Up @@ -173,6 +183,11 @@ struct mean_aggregation final : aggregation {
return {aggregation::SUM, aggregation::COUNT_VALID};
}
void finalize(aggregation_finalizer& finalizer) override { finalizer.visit(*this); }

std::unique_ptr<aggregation> clone() const override
{
return std::make_unique<mean_aggregation>(*this);
}
};

/**
Expand Down