Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing clone overrides on derived aggregations #6898

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Dec 3, 2020

Fixes #6891

Adds missing clone() overrides on aggregations that are derived but do not use derived_aggregation.

@jlowe jlowe added the libcudf Affects libcudf (C++/CUDA) code. label Dec 3, 2020
@jlowe jlowe self-assigned this Dec 3, 2020
@jlowe jlowe requested a review from a team as a code owner December 3, 2020 23:19
@jlowe jlowe added this to PR-WIP in v0.17 Release via automation Dec 3, 2020
@jlowe jlowe added the non-breaking Non-breaking change label Dec 3, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@jlowe jlowe added the bug Something isn't working label Dec 3, 2020
v0.17 Release automation moved this from PR-WIP to PR-Reviewer approved Dec 3, 2020
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this.

@harrism harrism added 6 - Okay to Auto-Merge 5 - Ready to Merge Testing and reviews complete, ready to merge labels Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #6898 (55d1e14) into branch-0.17 (e01ab96) will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #6898      +/-   ##
===============================================
- Coverage        82.31%   81.96%   -0.36%     
===============================================
  Files               93       96       +3     
  Lines            15358    16231     +873     
===============================================
+ Hits             12642    13303     +661     
- Misses            2716     2928     +212     
Impacted Files Coverage Δ
python/cudf/cudf/benchmarks/bench_cudf_io.py 30.61% <0.00%> (-12.25%) ⬇️
python/cudf/cudf/io/orc.py 88.40% <0.00%> (-9.22%) ⬇️
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (-7.40%) ⬇️
python/cudf/cudf/io/json.py 96.55% <0.00%> (-3.45%) ⬇️
python/cudf/cudf/io/avro.py 78.57% <0.00%> (-3.25%) ⬇️
python/cudf/cudf/io/csv.py 94.00% <0.00%> (-1.00%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.68% <0.00%> (-0.67%) ⬇️
python/cudf/cudf/core/column/string.py 86.30% <0.00%> (-0.59%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.53% <0.00%> (-0.46%) ⬇️
python/dask_cudf/dask_cudf/io/parquet.py 91.07% <0.00%> (-0.29%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af9bc0...55d1e14. Read the comment docs.

@rapids-bot rapids-bot bot merged commit e22c3ae into rapidsai:branch-0.17 Dec 4, 2020
v0.17 Release automation moved this from PR-Reviewer approved to Done Dec 4, 2020
@karthikeyann
Copy link
Contributor

Great catch.

@jlowe jlowe deleted the fix-agg-clone branch September 10, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
No open projects
v0.17 Release
  
Done
Development

Successfully merging this pull request may close these issues.

[BUG] Java aggregation tests are crashing the JVM
6 participants