Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(project): Cover unit and E2E test for disabled step #30 #31

Merged
merged 2 commits into from
Jun 14, 2023
Merged

test(project): Cover unit and E2E test for disabled step #30 #31

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
396b4f2
fix(lib): onClick is not updating currentStep if step is disabled #30
kevenleone Jun 11, 2023
3d90c28
test(project): Cover unit and E2E test for disabled step #30
kevenleone Jun 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(lib): onClick is not updating currentStep if step is disabled #30
  • Loading branch information
@kevenleone
kevenleone committed Jun 11, 2023
commit 396b4f26c3d989400cab99370cfc136fa981e6b7
2 changes: 1 addition & 1 deletion packages/headless-stepper/src/lib/hooks/useStepper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ const useStepper = ({
'aria-current': index === _currentStep ? 'step' : undefined,
'aria-selected': index === _currentStep,
onKeyDown: (event) => handleKeydown(event, index),
onClick: () => setCurrentStep(index),
onClick: () => (step.disabled ? null : setCurrentStep(index)),
ref: (element: HTMLElement) =>
(stepElementsRef.current[index] = element),
} as HTMLAttributes<HTMLElement>;
Expand Down