test(project): Cover unit and E2E test for disabled step #30 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
✅ Deploy Preview for headless-stepper canceled.
|
kevenleone
commented
Jun 11, 2023
packages/headless-stepper-e2e/src/integration/HeadlessStepper/HeadlessStepper.spec.ts
Show resolved
Hide resolved
kevenleone
commented
Jun 11, 2023
packages/headless-stepper-e2e/src/integration/HeadlessStepper/HeadlessStepper.spec.ts
Show resolved
Hide resolved
kevenleone
commented
Jun 11, 2023
packages/headless-stepper-e2e/src/integration/HeadlessStepper/HeadlessStepper.spec.ts
Show resolved
Hide resolved
|
Hi @kevenleone, thanks for this pull request, and the Cypress tests were a nice contribution too 🎉 |
raisiqueira
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Clicking on Step using onClick is not possible if step is disabled, from: #30
@raisiqueira I wrote E2E and Unit test to cover the expected behavior, let me know if it makes sense 👋🏻