Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: fix race condition when closing the RoundTripper #4458

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

marten-seemann
Copy link
Member

Fixes #4457.

@marten-seemann marten-seemann force-pushed the http3-fix-roundtrip-close-while-dialing branch from 04eac2e to 6af9768 Compare April 23, 2024 18:25
@marten-seemann marten-seemann force-pushed the http3-fix-roundtrip-close-while-dialing branch from 6af9768 to 880dad1 Compare April 23, 2024 18:30
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.71%. Comparing base (eb1c16b) to head (880dad1).

Files Patch % Lines
http3/roundtrip.go 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4458      +/-   ##
==========================================
+ Coverage   84.66%   84.71%   +0.05%     
==========================================
  Files         152      152              
  Lines       14409    14419      +10     
==========================================
+ Hits        12199    12215      +16     
+ Misses       1705     1700       -5     
+ Partials      505      504       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann merged commit 6a4512a into master Apr 23, 2024
34 checks passed
@marten-seemann marten-seemann deleted the http3-fix-roundtrip-close-while-dialing branch April 24, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in http3.RoundTripper.Close
1 participant