-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic in http3.RoundTripper.Close #4457
Comments
Thanks for reporting. Very valuable to get this resolved before shipping v0.43 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discovered while testing #4456.
Panic occurs in
RoundTripper.Close
here:My main hypothesis is that this occurs when there is a dialing error. See
RoundTripper.getClient
:Note how
cl.conn
is only set in the anonymous goroutine ifr.dial
is successful.Which means that
r.clients
can contain clients withconn == nil
, but methodsClose
,CloseIdleConnections
, andgetClient
all lack nil checks and assume that a non-nil*roundTripperWithCount
always has a non-nilconn
.The text was updated successfully, but these errors were encountered: