discard DATAGRAM frames that don't fit into packets without an ACK #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the packet doesn't contain an ACK (i.e. the payload is empty), there's no point retrying to pack it later. It's extremely unlikely that the available packet size will suddenly increase.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4221 +/- ##
==========================================
+ Coverage 83.95% 83.98% +0.02%
==========================================
Files 149 149
Lines 15405 15410 +5
==========================================
+ Hits 12933 12941 +8
+ Misses 1973 1971 -2
+ Partials 499 498 -1 ☔ View full report in Codecov by Sentry. |
chungthuang
approved these changes
Dec 30, 2023
|
Thank you @marten-seemann. This fixes the blocking problem we are seeing. |
chungthuang
approved these changes
Dec 31, 2023
|
Thanks for reviewing @chungthuang! |
|
Thank you @marten-seemann for the fix. |
nanokatze
pushed a commit
to nanokatze/quic-go
that referenced
this pull request
Feb 1, 2024
…uic-go#4221) If the packet doesn't contain an ACK (i.e. the payload is empty), there's no point retrying to pack it later. It's extremely unlikely that the available packet size will suddenly increase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4144. Closes #4145.
This PR implements part of my suggestion in #4145 (comment).
If the packet doesn't contain an ACK (i.e. the payload is empty), there's no point retrying to pack it later. It's extremely unlikely that the available packet size will suddenly increase.
Since we're relaxing the API guarantees (
SendDatagramdoesn't guarantee that the DATAGRAM frame is actually going to be sent out), this PR should allow us to move away from the blocking API (datagramQueue.AddAndWait) that's the main cause for the bad datagram performance (#3766).@joliveirinha @chungthuang @birneee Could you take a look at this PR please? Does this resolve your problem?