queue up to 32 DATAGRAM frames to send #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4222 +/- ##
==========================================
+ Coverage 83.96% 83.99% +0.04%
==========================================
Files 149 149
Lines 15410 15419 +9
==========================================
+ Hits 12938 12951 +13
+ Misses 1973 1970 -3
+ Partials 499 498 -1 ☔ View full report in Codecov by Sentry. |
chungthuang
reviewed
Dec 30, 2023
| "github.com/quic-go/quic-go/internal/utils" | ||
| "github.com/quic-go/quic-go/internal/wire" | ||
| ) | ||
|
|
||
| const ( | ||
| maxDatagramSendQueueLen = 32 |
There was a problem hiding this comment.
Can we make this configurable to let the users experiment with different queue size?
There was a problem hiding this comment.
I don't really want to add additional API surface here, but if your experimentation finds that this queue is too small, we can increase the queue size.
There was a problem hiding this comment.
magic environment variables would be useful here. Can label it alpha or beta to let people know it's going away
marten-seemann
force-pushed
the
datagram-queue-length
branch
from
b71a76b
to
93d8263
Compare
marten-seemann
changed the base branch from
discard-too-large-datagrams
to
master
nanokatze
pushed a commit
to nanokatze/quic-go
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3766.
@birneee Could you give this PR a try? Does it improve the datagram performance for your use case?