Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http3: add remote address to request context #4208

Merged
merged 2 commits into from
Dec 16, 2023
Merged

http3: add remote address to request context #4208

merged 2 commits into from
Dec 16, 2023

Commits on Dec 14, 2023

  1. http3: add remote address to request context 

    Add the remote address of the underlying packet connection to the
HTTP request context. This is useful for applications that need access
to the actual remote address (wrapped in a net.Addr) rather than just
its string representation.

Fixes quic-go#4198
    @oncilla
    oncilla committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c932515 View commit details
    Browse the repository at this point in the history

  2. add an integration test to the self test suite. 

    I was not sure how deep we want to go to assure the right value is set.
For now, it asserts that a net.Addr is present in the context.

Due to the dynamic nature of the requests, it is a bit harder to know
exactly how the remote address will look like. IPv4 vs IPv6, random high
port. I think it is fine to only assert that the value is present.
    @oncilla
    oncilla committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    7d28c30 View commit details
    Browse the repository at this point in the history